Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Wrote for adding chromium #149

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Conversation

meets2tarun
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (provide a screenshot or link for test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Work on the issue #121

@xeon-zolt
Copy link
Member

will chromium work on meilix ? 64 bit support only !!

@meets2tarun
Copy link
Member Author

@xeon-zolt
Yes, there is chromium exist for 32 bit also.

Copy link
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a skeleton code which can guide further development.

@@ -36,6 +36,7 @@ def index():
email = request.form['email']
TRAVIS_TAG = request.form['TRAVIS_TAG']
event_url = request.form['event_url']
GENERATOR_ = request.form['GENERATOR_']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
To get all variables, you should be able to do something like

variables = {}
for name, value in request.form.items():
    if name.startswith("GENERATOR_"):
        variables[name] = value

@@ -0,0 +1,3 @@
#!/bin/bash
if echo "$GENERATOR_package_chromium" | grep -q chromium; then
sudo apt-get install -q -y chromium; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@@ -499,7 +499,7 @@
<tbody>
<tr>
<td>Chromium</td>
<td><input type="checkbox"></td>
<td><input name="GENERATOR_package_chromium" type="checkbox" value="chromium" id="chromium"></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am excited to see this in action one day.

@niccokunzmann niccokunzmann merged commit ee8a375 into fossasia:master Jun 13, 2018
@meets2tarun meets2tarun deleted the script branch June 14, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants