Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing hostname on the generated ISO #103

Merged
merged 2 commits into from
Aug 5, 2017

Conversation

xeon-zolt
Copy link
Member

@xeon-zolt xeon-zolt commented Jul 22, 2017

Short description

I have:

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

@@ -38,6 +38,9 @@ chmod +x meilix-generator.sh
echo "$(<meilix-generator.sh)" #to test the file
./meilix-generator.sh
rm meilix-generator.sh

#change host name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may solve the #104 ?
or consider including this all fossasia/meilix-generator#79 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it does not solves #104
I have not tested it for user name change so not including last two lines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnot add hotelos user but an user from the travis tag right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeon-zolt As this whole PR is just two lines of code, does this mean you retract the two lines of code and seek a different solution?

@tabesin
Copy link
Member

tabesin commented Jul 27, 2017

The PR naming "this for" is a bit unclear, please improve.

@abishekvashok
Copy link
Member

Please change your PR title, commit message etc to make it look more professional

See this: https://chris.beams.io/posts/git-commit/ ,
this: https://gist.github.com/matthewhudson/1475276 ,
and this: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst

@tabesin tabesin changed the title this for changing hostname on generated ISO Changing hostname on the generated ISO Jul 29, 2017
@tabesin tabesin merged commit 15c3183 into fossasia:generator Aug 5, 2017
@xeon-zolt xeon-zolt deleted the hostname branch October 8, 2017 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants