-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing hostname on the generated ISO #103
Conversation
@@ -38,6 +38,9 @@ chmod +x meilix-generator.sh | |||
echo "$(<meilix-generator.sh)" #to test the file | |||
./meilix-generator.sh | |||
rm meilix-generator.sh | |||
|
|||
#change host name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may solve the #104 ?
or consider including this all fossasia/meilix-generator#79 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it does not solves #104
I have not tested it for user name change so not including last two lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesnot add hotelos user but an user from the travis tag right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeon-zolt As this whole PR is just two lines of code, does this mean you retract the two lines of code and seek a different solution?
The PR naming "this for" is a bit unclear, please improve. |
Please change your PR title, commit message etc to make it look more professional See this: https://chris.beams.io/posts/git-commit/ , |
Short description
I have:
Fixes #change the user name and host name with the name of the event meilix-generator#79
For the reviewers
I have: