fix(cheatcode): expect revert only for calls with greater depth than test #9537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
added
the
T-likely-breaking
grandizzy
force-pushed
the
issue-7238
branch
2 times, most recently
from
dccc236 to
8a0ea49
Compare
grandizzy
changed the title
grandizzy
force-pushed
the
issue-7238
branch
from
8a0ea49 to
284b0fc
Compare
grandizzy
force-pushed
the
issue-7238
branch
from
284b0fc to
93aec03
Compare
grandizzy
force-pushed
the
issue-7238
branch
from
377735c to
df77c40
Compare
grandizzy
changed the title
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
grandizzy
changed the title
mattsse
approved these changes
Jan 24, 2025
| @@ -86,6 +86,7 @@ contract AttachDelegationTest is DSTest { | |||
| assertEq(token.balanceOf(bob), 200); | |||
| } | |||
|
|
|||
| /// forge-config: default.allow_internal_expect_revert = true | |||
There was a problem hiding this comment.
unrelated, pretty cool that this works
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3723
Closes #7238
Closes #3437
Breaking change, should be merged after pinned version.
expectRevert, compares with test depth (at which cheatcode was added). Does not apply for_expectCheatcodeRevertcalls.allow_internal_expect_revertconfig to enable expect reverts for internal calls. defaults to falseSolution