debt(forge): remove testFail*
#9574
Open
+1,968
−1,071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
added
T-likely-breaking
DaniPopes
reviewed
Dec 19, 2024
yash-atreya
changed the title
forge): deprecate testFail*forge): remove testFail*
Moved to ExpectRevertFailures.t.sol in cli tests
yash-atreya
force-pushed
the
yash/fix-4437
branch
from
60e0887 to
1eda9a5
Compare
* rm `should_fail` from runner and TestFunctionKind * update, document and add additional external tests * remove newly added morpho for now * fix --------- Co-authored-by: Yash Atreya <[email protected]>
yash-atreya
requested review from
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
DaniPopes
requested changes
Jan 26, 2025
| .collect::<Vec<_>>(); | ||
|
|
||
| if !test_fail_instances.is_empty() { | ||
| return SuiteResult::new(start.elapsed(),[(format!("Found {} instances: {}", test_fail_instances.len(), test_fail_instances.join(", ")), TestResult::fail("`testFail*` has been deprecated. Consider changing to test_Revert[If|When]_Condition and expecting a revert".to_string()))].into(), warnings) |
There was a problem hiding this comment.
please split into multiple variables to make formatting work again
| .collect::<Vec<_>>(); | ||
|
|
||
| if !test_fail_instances.is_empty() { | ||
| return SuiteResult::new(start.elapsed(),[(format!("Found {} instances: {}", test_fail_instances.len(), test_fail_instances.join(", ")), TestResult::fail("`testFail*` has been deprecated. Consider changing to test_Revert[If|When]_Condition and expecting a revert".to_string()))].into(), warnings) |
There was a problem hiding this comment.
Suggested change
| return SuiteResult::new(start.elapsed(),[(format!("Found {} instances: {}", test_fail_instances.len(), test_fail_instances.join(", ")), TestResult::fail("`testFail*` has been deprecated. Consider changing to test_Revert[If|When]_Condition and expecting a revert".to_string()))].into(), warnings) | |
| return SuiteResult::new(start.elapsed(),[(format!("Found {} instances: {}", test_fail_instances.len(), test_fail_instances.join(", ")), TestResult::fail("`testFail*` has been removed. Consider changing to test_Revert[If|When]_Condition and expecting a revert".to_string()))].into(), warnings) |
| // This is to ensure that we don't have any stale snapshots. | ||
| // If `FORGE_SNAPSHOT_CHECK` is set, we don't remove the snapshots directory as it is | ||
| // required for comparison. | ||
| if std::env::var_os("FORGE_SNAPSHOT_CHECK").is_none() { |
There was a problem hiding this comment.
this looks unrelated / merge artifact
| Self::UnitTest { should_fail: true } => "testFail", | ||
| Self::FuzzTest { should_fail: false } => "fuzz", | ||
| Self::FuzzTest { should_fail: true } => "fuzz fail", | ||
| Self::UnitTest { should_fail } => { |
There was a problem hiding this comment.
please revert, this is strictly worse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4437
Solution
testFail*.testFail*, to cli tests to assert internal tooling failure. See failure_assertions.rs