Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: derive block gas limit from rpc for forge script and anvil when forking #9753

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: derive block gas limit from rpc for forge script and anvil when forking #9753

wants to merge 3 commits into from

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jan 24, 2025 •
edited
Loading

Motivation

Closes: #9752
Closes: #9723

Solution

  • Fixes gas_limit as reported by Anvil

When forking Sonic, has 1 billion gas limit: anvil --fork-url https://rpc.soniclabs.com

Previously reported:

Gas Limit
==================

30000000

Fixed:

Gas Limit
==================

1000000000

Tested against both repro's in and works as expected

Opening for visibility, still want to add a few tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy will be requested when the pull request is marked ready for review grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya will be requested when the pull request is marked ready for review yash-atreya is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
1 participant
@zerosnacks