-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a design doc for prepare
cheatcode
#63
Comments
We should write a design doc for this first |
Prepare
cheat code in rust and update Deploy
logic #1991prepare
cheatcode
Usecases for having the
In my opinion the current flow with just I'd avoid requiring the user to do What's problematic is for this precalculation to work, addresses would have to be deterministic: This is possible, but would then limit the user to only having one instance of a given contract. Perhaps this could be solved by using some kind of internal "counter" that would be incremented on every deployment and used as a salt for contract address. This way the address would could be precalculated without requiring the user to do so before every deployment. |
<!-- Reference any GitHub issues resolved by this PR --> Closes #63 ## Introduced changes <!-- A brief description of the changes --> - Add design document discussing and proposing a solution in place of `prepare` cheaatcode. ## Breaking changes <!-- List of all breaking changes, if applicable --> ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Piotr Magiera <[email protected]>
* update to alpha.4 * add corelib * comment out breaking changes exercises * fix options3 exercise toward alpha.4 * use integers instead of felt for some exercises * fix options1 and struct3 * update(alpha4): address PR review --------- Co-authored-by: msaug <[email protected]>
Create a design document for
prepare
cheatcode or alternative solution.The text was updated successfully, but these errors were encountered: