-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add block_explorer field to ShowConfigResponse #2750
Open
mexes20
wants to merge
7
commits into
foundry-rs:master
Choose a base branch
from
mexes20:block_explorer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9c3fa02
feat: Add block_explorer field to ShowConfigResponse
mexes20 509b0c8
Merge branch 'master' into block_explorer
mexes20 1a4f30a
test to cover both default and non-default block-explorer cases
mexes20 8921cde
Merge branch 'master' into block_explorer
mexes20 2d4117b
fix
mexes20 6d6927b
Merge branch 'block_explorer' of https://github.com/mexes20/starknet-…
mexes20 606d0d5
Merge branch 'master' into block_explorer
mexes20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,3 +128,40 @@ async fn test_show_config_no_url() { | |
wait_timeout: 500 | ||
"}); | ||
} | ||
|
||
#[tokio::test] | ||
async fn test_show_config_default_block_explorer() { | ||
let tempdir = copy_config_to_tempdir("tests/data/files/correct_snfoundry.toml", None).unwrap(); | ||
let args = vec!["show-config"]; | ||
let snapbox = runner(&args).current_dir(tempdir.path()); | ||
snapbox.assert().success().stdout_eq(formatdoc! {r" | ||
command: show-config | ||
account: user1 | ||
accounts_file_path: ../account-file | ||
chain_id: alpha-sepolia | ||
rpc_url: {} | ||
block_explorer: StarkScan | ||
show_explorer_links: true | ||
wait_retry_interval: 5 | ||
wait_timeout: 300 | ||
", URL}); | ||
} | ||
|
||
#[tokio::test] | ||
async fn test_show_config_custom_block_explorer() { | ||
let tempdir = copy_config_to_tempdir("tests/data/files/correct_snfoundry.toml", None).unwrap(); | ||
let args = vec!["--profile", "profile5", "show-config"]; | ||
let snapbox = runner(&args).current_dir(tempdir.path()); | ||
snapbox.assert().success().stdout_eq(formatdoc! {r" | ||
command: show-config | ||
account: user3 | ||
accounts_file_path: ../account-file | ||
chain_id: alpha-sepolia | ||
profile: profile5 | ||
rpc_url: {} | ||
block_explorer: blockscout | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This blok explorer is not supported, please add the custom check for |
||
show_explorer_links: true | ||
wait_retry_interval: 5 | ||
wait_timeout: 300 | ||
", URL}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check can be added in the
test_show_config_from_snfoundry_toml
instead of creating a separate test