Add readline ignore sequences to PS1 #1041
Conversation
This adds RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE sequences to PS1. Fixes #1003
|
And tab completion still works :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 78.24% 78.24%
=======================================
Files 336 336
Lines 29673 29673
=======================================
Hits 23217 23217
Misses 6456 6456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can you add a unit test for tab completion 😉 |
|
I think we can test tab completion in a similar fashion as pypy does: pypy/pypy@2c7ab72#diff-29b9d7f8caca9a166907d2bb7ead6c15a939e9dba3ca8b9d76ba0af97729cb18 |
|
Added test using pexpect, thanks for the tip :) I also found an issue when creating the test, the output of
notice that |
|
Skipping the test on Windows due to missing pexpect. I'm not sure why the test fails on PyPy. Will look into this another time. |
- First of all it doesn't seem to work at all in GitHub CI (timeout reached with no output). - On local tests, the PyPy's REPL output contains too much ANSI escape codes. Not colors, but like turning off cursor, or bracketed pasting codes which messes with the simplicity of the current matching code.
This adds RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE sequences to PS1.
Fixes #1003