Merge pull request #8 from franleplant/make-data-optional

feature: make data in emitTo* methods be optional
franleplant · Dec 25, 2020 · 8b13eb1 · 8b13eb1
2 parents f1be11d + 200bdaa
commit 8b13eb1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1,6 @@
+# [unreleased minor] 2020-12-23
+
+### Changed
+
+- the second argument `data` for `ichild.emitToParent` and `iparent.emitToChild` is optional now
+
diff --git a/src/Child.ts b/src/Child.ts
@@ -80,7 +80,7 @@ export default class ChildAPI<TModel, TContext = any> extends Emittery {
     }
   }
 
-  emitToParent(eventName: string, data: unknown): void {
+  emitToParent(eventName: string, data?: unknown): void {
     debug(`emitToParent "%s" with data %O`, eventName, data);
 
     this.parent.postMessage(

diff --git a/src/Parent.ts b/src/Parent.ts
@@ -85,7 +85,7 @@ export default class ParentAPI extends Emittery {
     }
   }
 
-  emitToChild(eventName: string, data: unknown): void {
+  emitToChild(eventName: string, data?: unknown): void {
     debug(`emitToChild "%s" with data %O`, eventName, data);
 
     this.child.postMessage(createParentEmit(eventName, data), this.childOrigin);