Added min/max check; fixed behavior if max is null and min is not

franzose · Jun 26, 2018 · 6abbd19 · 6abbd19
1 parent 5c48679
commit 6abbd19
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/Rules/Core/Length.php b/src/Rules/Core/Length.php
@@ -52,7 +52,11 @@ public function __construct(
             throw new InvalidArgumentException('Either option "min" or "max" must be given.');
         }
 
-        if ($max < $min) {
+        if ($min !== null && $min > $max) {
+            throw new LogicException('"Min" option cannot be greater that "max".');
+        }
+
+        if ($max !== null && $max < $min) {
             throw new LogicException('"Max" option cannot be less that "min".');
         }
 

diff --git a/src/Rules/Core/Range.php b/src/Rules/Core/Range.php
@@ -37,7 +37,11 @@ public function __construct($min = null, $max = null)
             throw new InvalidArgumentException('Either option "min" or "max" must be given.');
         }
 
-        if ($max < $min) {
+        if ($min !== null && $min > $max) {
+            throw new LogicException('"Min" option cannot be greater that "max".');
+        }
+
+        if ($max !== null && $max < $min) {
             throw new LogicException('"Max" option cannot be less that "min".');
         }