Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: '0' rate LDC's Invoice net totals should be ignored (backport #45639) #45784

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

| Dec 2024 | Jan 2025 |
|          |          |
| LDC @ 0% |          |
|----------+----------|
| pinv1    | pinv3    |
| pinv2    |          |

Consider above scenario, LDC of '0' rate active for December 2024 and thera are purchase invoices booked in that period. Now, when a purchase invoice is created outside LDC, system incorrectly considers net total of pinv1 and pinv2 on TDS calculation as there are no taxes on the previous entries.

todo:

  • test case

This is an automatic backport of pull request #45639 done by [Mergify](https://mergify.com).

(cherry picked from commit 0cdd346)

# Conflicts:
#	erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py
@mergify mergify bot requested a review from deepeshgarg007 as a code owner February 7, 2025 07:44
@mergify mergify bot added the conflicts label Feb 7, 2025
@mergify mergify bot requested a review from ruthra-kumar as a code owner February 7, 2025 07:44
Copy link
Contributor Author

mergify bot commented Feb 7, 2025

Cherry-pick of 0cdd346 has failed:

On branch mergify/bp/version-15-hotfix/pr-45639
Your branch is ahead of 'origin/version-15-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 0cdd346f8f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ruthra-kumar ruthra-kumar merged commit a7d32b5 into version-15-hotfix Feb 7, 2025
11 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-45639 branch February 7, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant