fix: payroll entry -> salary slip: with add salary, the deduction not correctly computed #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not correctly computed When a deduction component is computed based on earning component which is an additional salary, the sequence of computation result in invalid deduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a deduction component is computed based on earning component which is an additional salary, the sequence of computation result in invalid deduction.
ERPNext: v15.51.1 (version-15)
Frappe Framework: v15.55.2 (version-15)
Frappe HR: v15.39.1 (version-15)
NOTE: This bug happen only case when Salary Slip is created from Payroll Entry and not when create Salary Slip directly.
Here is the deduction component formula, part of it based on Additional Salary (BACK), which will be part of earning.
Payroll Entry -> Create Salary Slip, looks like the PVD is computed when Additional Salary is not yet recognized.
If recomputed (by updating or with the proposed fix in this PR), now it is good.