Update README.md #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazieje
reviewed
Apr 29, 2024
| - Calculate your own Pi data file with [y-cruncher](http://www.numberworld.org/y-cruncher/) | ||
| - Perform the following steps: | ||
|
|
||
| 1. Set the location of the file as an environment variable: |
There was a problem hiding this comment.
I like the update to use an unordered list for the data file options, but this line about setting the location of the file starts the next section, which should be titled "Configuring the data file" or "using your data file" or something like that
frazieje
reviewed
Apr 29, 2024
| ```shell | ||
| $ ./gradlew run -PpiData=[location of data file] | ||
| ``` | ||
|
|
||
| ### Usage | ||
| To use the HTTP API once running: | ||
| After you run the program, use the HTTP API: |
There was a problem hiding this comment.
"After you run the program, use the HTTP to search for a number in Pi:"
Should we also mention that they need to update the searchText to whatever number they want to search for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.