Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change clean intake/eject to a PID command #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change clean intake/eject to a PID command #57

wants to merge 1 commit into from

Conversation

StarryNight7210
Copy link
Contributor

No description provided.

@StarryNight7210 StarryNight7210 requested a review from Xanawatt April 9, 2024 23:46
@Xanawatt Xanawatt changed the title changed it to the PID command Change clean intake/eject to a PID command Apr 9, 2024
Xanawatt
Xanawatt reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Xanawatt Xanawatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but needs to be tested

seliger
seliger reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@seliger seliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given Elliot's tweaks to the intake, do you think this is still necessary? This will not make the cut for IRI, but it may be worthwhile to continue digging into this to better understand PIDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seliger seliger seliger left review comments

@Xanawatt Xanawatt Xanawatt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StarryNight7210 @seliger @Xanawatt