Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/refactor(build/test): change build java job to test java #13

Closed
wants to merge 2 commits into from

Conversation

Baconing
Copy link
Member

@Baconing Baconing commented Oct 10, 2024

since testing will build anyway, and we don't upload any artifacts from the build

also changes the "build" step in publish to "publish" because it was bothering me

Summary by CodeRabbit

  • New Features

    • Introduced several new JSON configuration files for various libraries, enhancing dependency management for the 2024 FRC season.
    • Updated workflow configurations for Gradle publishing and Java testing to improve build and deployment processes.
  • Improvements

    • Restructured deployment configurations in the Gradle build file for better artifact management.
    • Enhanced project settings with a new pluginManagement block for streamlined plugin handling.
  • Bug Fixes

    • Corrected job names and commands in GitHub Actions workflows to accurately reflect their purposes.
  • Documentation

    • Added metadata for new libraries, including NavX, PathplannerLib, Phoenix5, Phoenix6, REVLib, URCL, and others, providing clear versioning and dependency information.

…or deps.

allows for implementation of JNI libraries in unit testing
since testing will build anyway, and we don't upload any artifacts from the build

also changes the "build" step in publish to "publish" because it was bothering me
@Baconing Baconing added the Kind/Testing Issue or pull request related to testing label Oct 10, 2024
@Baconing Baconing added this to the Version: 2025-1.0.0 milestone Oct 10, 2024
@Baconing Baconing requested a review from Trip-kun October 10, 2024 17:19
@Baconing Baconing self-assigned this Oct 10, 2024
Copy link

coderabbitai bot commented Oct 10, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes primarily focused on workflow configurations and library metadata for a robotics project. The GitHub Actions workflows have been updated to reflect new job names and purposes, specifically transitioning from building to testing and publishing. Additionally, multiple JSON files have been added to define metadata and dependencies for various libraries, enhancing the project's modularity and integration capabilities.

Changes

File Change Summary
.github/workflows/grade-publish.yml Workflow name remains "Gradle Publish"; job name changed to publish; added "Set Outputs" step.
.github/workflows/test-java.yml Workflow name changed to "Test Java"; job name changed to test-java; replaced build step with test step.
build.gradle Added edu.wpi.first.GradleRIO plugin; restructured deployment configurations; updated dependencies.
settings.gradle Added pluginManagement block for Gradle plugins; configured frcHome directory based on OS.
.wpilib/wpilib_preferences.json New configuration file created with project settings for WPILib framework.
vendordeps/*.json Multiple new JSON files added for various libraries (NavX, PathplannerLib, Phoenix5, Phoenix6, REVLib, URCL, WPILibNewCommands, photonlib, yagsl) detailing their metadata and dependencies.

Possibly related PRs

Suggested labels

Kind/Enhancement

Suggested reviewers

  • Trip-kun

🐰 In the meadow, changes bloom,
Workflows shift, dispelling gloom.
JSON files dance with metadata bright,
Libraries ready, all set for flight!
Hops of joy, a project anew,
With each commit, we craft and pursue! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Baconing
Copy link
Member Author

Messed up the branch

@Baconing Baconing closed this Oct 10, 2024
@Baconing Baconing deleted the v2025-1-0-0/test-ci branch October 10, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Testing Issue or pull request related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant