fix/ci(workflows/pmd): fail build if pmd detects violations #2
Conversation
Signed-off-by: Bacon <[email protected]>
|
Warning Rate limit exceeded@Baconing has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 52 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes to the PMD GitHub Action workflow enhance its error handling and reporting capabilities. A new step titled "PMD failed" has been introduced to evaluate the outcome of the PMD analysis, allowing the workflow to react appropriately when violations are detected. By referencing the PMD analysis outputs, these modifications improve the overall control flow and reliability of the CI/CD process. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/pmd.yml (1 hunks)
Additional context used
actionlint
.github/workflows/pmd.yml
31-31: step must run script with "run" section or run action with "uses" section
(syntax-check)
Additional comments not posted (1)
.github/workflows/pmd.yml (1)
25-29: LGTM! The addition ofid: pmdis correct.This change allows the subsequent step to reference the outputs from the PMD analysis.
Signed-off-by: Bacon <[email protected]>
The PMD check does not fail if it detects more than one violation, this PR resolves that. (#2) * fix/ci(workflows/pmd): fail build if pmd detects violations * fix(ci/pmd): actually fail the check --------- Signed-off-by: Bacon <[email protected]>
The PMD check does not fail if it detects more than one violation, this PR resolves that.
Summary by CodeRabbit