[pull] master from ytti:master #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
When masking changing values, we were seeing the whitespace after the regex replace changing when the value being masked changed in length (e.g. fan speed went from 9750 to 10000 rpm). This caused unneccessary commits.
If you realy want the full configuration with default variables, use 'fullconfig' in oxidized condiguration. Closes: #3159
aoscx.rb: improve regex replacement to avoid whitespace commits
\h means hex character, not horizontal whitespace, in ruby regex so while it still matched rpm numbers it wasn't actually fixing the problem
With this class we can utilise JSON files directly without the redirection via a HTTP server. This massivly improved our configuration delivery process, because we are able to deliver cached configuration to oxidized without changes on the delivering service, which would have been much more complicated.
oxidized-web uses the exception NodeNotFound, but it was not produced in oxidized. Fixing without documentation in CHANGELOG.md as no user impact.
Add NSW DFW support
Update dependency of psych version
- Psych > 5 needs libyaml-dev. Added it an splited the loooong line of packages - Added ENV DEBIAN_FRONTEND=noninteractive to avoid questions during apt-get install (msmtp aksing if the apparmor profile should be used)
rubocop and not that important i guess
- After rebasing PR #3105 on master, the position in the CHANGELOG had to be moved to the [Unreleased] section. - The use of '...' in yaml means next file, which produces problems in the interpreation of Markdown. Changed to '# ...' - Removed trainling spaces
Add JSON source class.
Updated slackdiff document to highlight channel id is required
Either unencrypted (0) or encrypted (7) secrets should be hidden
Using an FS S34000 fully configured switch with AAA and SNMP
Terminal width was insufficient, especially for long SNMP auth/priv hashes
This is to fix issue #3330 so multiline output won't break the module. Some cumulus commands results do not end with \n, so the prompt gets polluted by the trailing line of the previous command. This is the case of `cat /etc/cumulus/ports.conf`, so we an echo to it to get an LF at EOF.. --------- Co-authored-by: Robert Cheramy <[email protected]> Co-authored-by: Michał Margula <[email protected]>
trying to resolve issue #3351
feat(fsos): Hiding AAA and SNMP secrets
- I've removed the TargetRubyVersion in rubocop.yml whith the hope it will use the RubyVersion used in the CI test. - Updated the minitestversion or it will fail with Ruby 3.5 when mutex_m is not a development_dependency. - If ruby-head fails, don't stop the other tests
k = '' loop do k << 'a' end Wont work in future, because k is string literal, therefore frozen/immutable, and String#<< method tries to mutate it. Fixes are k = String.new k = '' + '' # expression is not string literal k = ''.dup
From ruby 3.5.0 forward ostruct won't be available by standard
This commit introduces ATOMS (Automatic Trivial Oxidized Model Spec), which greatly simplifies model unit tests. Most of the code is from @ytti, @robertcheramy documented it and updated device2yaml.rb. --------- Co-authored-by: Saku Ytti <[email protected]>
Fixes #3371
3351 fix aos7 prompt
* Allow using regexp for model_map and group_map keys Use case is that the source returns string which has unrelated and variant data but the actual model is included somewhere in this data For example source could have space separated list of tags and one of these tags could be model name. Eg 'procurve switch'. Closes #3360 * stop normalising config keys into string * comment and document regexp maps --------- Co-authored-by: Robert Cheramy <[email protected]>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.69.0...v1.71.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Fixes for Cisco ASA model (asa.rb)
Having a failed CI because of the test coverage is not useful. We don't need a CI for test coverage.
... confunded codeql and codecov in last commit...
…tw-1.71.0 Update rubocop requirement from ~> 1.69.0 to ~> 1.71.0
[AOSW]: exclude power measurements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )