Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: overwrite buffer in cleanupDatalog() #620

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

dukess
Copy link
Contributor

@dukess dukess commented Feb 25, 2024

No description provided.

@dukess
Copy link
Contributor Author

dukess commented Feb 25, 2024

BTW: should we define separate buffers for client, debug and file outputs?

@fredlcore
Copy link
Owner

Thanks! I have no Due at the moment where I could check whether this (seriously) affects free RAM, but if the buffers are just created temorarily, then it shouldn't be an issue, right?

@fredlcore fredlcore merged commit 32eeec3 into fredlcore:master Feb 25, 2024
2 checks passed
@DE-cr
Copy link
Contributor

DE-cr commented Sep 18, 2024

The use of a temporary char* here doesn't make a difference.
Whether flushToWebClient() does here, I cannot easily tell, but I would expect that right before processing a new url command, that buffer should be flushed.
Anyway, the code change should not hurt, except for a few bytes more in the size of bsb-lan's binary. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants