-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade node version #291
chore: upgrade node version #291
Conversation
9add85b
to
830e50e
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
"node": ">= 14.0.0", | ||
"npm": "6.14.18" | ||
"node": ">= 18.0.0", | ||
"npm": ">= 9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest npm version is 10, but it's quite new so I would rather wait until other dependencies are fairly up-to-date.
I'm using Node 18 and npm 9 on my machine, and things are working properly.
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import EventSource from 'eventsourcemock'; | ||
import '@testing-library/jest-dom'; | ||
|
||
Object.defineProperty(window, 'EventSource', { | ||
value: EventSource | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a failing test in the repo:
![Screenshot 2023-10-12 at 00 50 34](https://private-user-images.githubusercontent.com/25715018/274370539-57d6041e-a976-484e-a4f0-2b2eb5837f21.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2Mzk0MzgsIm5iZiI6MTczOTYzOTEzOCwicGF0aCI6Ii8yNTcxNTAxOC8yNzQzNzA1MzktNTdkNjA0MWUtYTk3Ni00ODRlLWE0ZjAtMmIyZWI1ODM3ZjIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE3MDUzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyMzY2M2YzNjNhNmU2NjRiYTc5NWExNDAzMTUzZDJmNTI5NjdkYjE1MzU2MjM2MTFiZWQ1ZDM2NzIwZjA1YTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AjE4BdbHW9aqxGkokBDEJyN-aOTmMIc3IJc8xZW7WBQ)
I was able to fix it following this guide: https://stackoverflow.com/a/75390265 (required adding eventsourcemock
as a dev dependency).
0cc1fd4
to
2e15843
Compare
Sigh. There is a conflict in the React version we use and I'll raise a PR to upgrade |
Closing as fixed in #308 |
Checklist:
Update index.md
)Upgrade Node version to 18 as v14 is no longer supported.
Ref: https://endoflife.date/nodejs