fix: lowercase directories, not files #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojeytonwilliams
force-pushed
the
fix/lowercase-directories-not-files
branch
from
54ed87b to
2dffc90
Compare
ShaunSHamilton
approved these changes
Jun 11, 2024
|
No, that's a good point. Thanks, Shaun. I'll update that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)As written the plugin was making files lowercase and ignoring directories.
Also life gets a little simpler if you update the directories as you recurse, rather than gathering them all and lowercasing. Reason being, if you have a nested directories, then you have to have rename the children first. If you rename as you descend into the tree, this problem goes away.