-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Spacer component #248
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { Spacer } from "./spacer"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import React from "react"; | ||
import { Meta, StoryFn, StoryObj } from "@storybook/react"; | ||
import { Spacer } from "./spacer"; | ||
import { Button } from "../button"; | ||
|
||
const story = { | ||
title: "Components/Spacer", | ||
component: Spacer, | ||
} satisfies Meta<typeof Spacer>; | ||
|
||
type Story = StoryObj<typeof Spacer>; | ||
|
||
const Template: StoryFn<typeof Spacer> = (args) => ( | ||
<> | ||
<Button>Button one</Button> | ||
<Spacer {...args} /> | ||
<Button>Button two</Button> | ||
</> | ||
); | ||
|
||
export const XXS: Story = { | ||
render: Template, | ||
args: { | ||
size: "xxs", | ||
}, | ||
}; | ||
|
||
export const XS: Story = { | ||
render: Template, | ||
args: { | ||
size: "xs", | ||
}, | ||
}; | ||
|
||
export const S: Story = { | ||
render: Template, | ||
args: { | ||
size: "s", | ||
}, | ||
}; | ||
|
||
export const M: Story = { | ||
render: Template, | ||
args: { | ||
size: "m", | ||
}, | ||
}; | ||
|
||
export const L: Story = { | ||
render: Template, | ||
args: { | ||
size: "l", | ||
}, | ||
}; | ||
|
||
export const XL: Story = { | ||
render: Template, | ||
args: { | ||
size: "xl", | ||
}, | ||
}; | ||
|
||
export const XXL: Story = { | ||
render: Template, | ||
args: { | ||
size: "xxl", | ||
}, | ||
}; | ||
|
||
export default story; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import React from "react"; | ||
|
||
const sizes = { | ||
xxs: "h-[5px]", | ||
xs: "h-[10px]", | ||
s: "h-[20px]", | ||
m: "h-[30px]", | ||
l: "h-[60px]", | ||
xl: "h-[90px]", | ||
xxl: "h-[180px]", | ||
} as const; | ||
|
||
interface SpacerProps { | ||
/** | ||
* Sizes: | ||
* - xxs: 5px | ||
* - xs: 10px | ||
* - s: 20px | ||
* - m: 30px | ||
* - l: 60px | ||
* - xl: 90px | ||
* - xxl: 180px | ||
*/ | ||
Comment on lines
+14
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
size: keyof typeof sizes; | ||
} | ||
|
||
export const Spacer = ({ size }: SpacerProps) => { | ||
// NOTE: Do not construct class names dynamically | ||
// https://tailwindcss.com/docs/content-configuration#classes-arent-generated | ||
return <div className={sizes[size]} />; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The /learn Spacer accepts children, which was needed to account for a section on the profile page (freeCodeCamp/freeCodeCamp#49828). The rendering logic of the page has changed and I'm not seeing this kind of usage anywhere in /learn, so I'm not including this feature in the new version.
IMHO, I don't think Spacer should accept any children. As the name implies, it should just be a simple block or gap. Anything fancier should be handled by a layout component (#13).