fix(us_backscrapers.mass): fix extract from text #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #1234 fixed indexing errors in extract_from_text
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: juriscraper/opinions/united_states_backscrapers/state/mass.py
Did you find this useful? React with a 👍 or 👎 |
flooie
reviewed
Nov 12, 2024
| @@ -148,11 +148,11 @@ def make_backscrape_iterable(self, kwargs: dict) -> None: | |||
| now = datetime.now() | |||
|
|
|||
| if start: | |||
| start = datetime.strptime(start, "%m/%d/%Y") | |||
| start = datetime.strptime(start, "%Y/%m/%d") | |||
There was a problem hiding this comment.
are we sure this works. this is a weird back scraper
There was a problem hiding this comment.
I have tested this, and it works. If I remember correctly, we actually implemented #1155 inspired by this single extract_from_text bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1234
fixed indexing errors in extract_from_text