Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idaho, idahoctapp): update to OpinionSiteLinear #1279

Merged
merged 3 commits into from
Dec 31, 2024
Merged

fix(idaho, idahoctapp): update to OpinionSiteLinear #1279

merged 3 commits into from
Dec 31, 2024

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Dec 30, 2024

Solves #1278

Bug was caused by a multi line docket number; easiest way to fix this was updating to OpinionSiteLinear

  • simplified logic
  • deleted redundant example files
  • updated usage of __init__ in inheriting scrapers

Solves #1278

Bug was caused by a multi line docket number; easiest way to fix this was updating to OpinionSiteLinear
- simplified logic
- deleted redundant example files
- updated usage of `__init__` in inheriting scrapers
@grossir grossir requested a review from flooie December 30, 2024 16:36
@flooie
Copy link
Contributor

flooie commented Dec 31, 2024

I havent done an extensive check but can you look at the docket numbers for cases with multiple docket numbers.

it gets returned as

docket_numbers: "39077/ 39078/ 39079"

instead of

Docket Nos. 39077/39078/39079

See
https://isc.idaho.gov/opinions/39077and39078and39079opn.pdf

Probably just a minor tweak to whitespace?

@flooie flooie merged commit a6a8533 into main Dec 31, 2024
12 checks passed
@flooie flooie deleted the fix_idaho branch December 31, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants