Remove remaining pieces that depend on Poppler #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This most obviously includes the Poppler backend, but also the EPS exporter. As discussed under frescobaldi#32, there is currently no python-poppler-qt6, and little interest in creating one now that QtPdf satisfies our needs. It would therefore make sense to drop Poppler support rather than continue to include a feature we do not need using a binding we do not control. This PR is mutually exclusive with frescobaldi#33 and intended to follow frescobaldi/frescobaldi#1832, which removes the last Poppler-dependent features from Frescobaldi.
I wasn't sure if there was a consensus to remove Poppler support, so I was trying to leave options open. But yes, my vote would be for this one over #33. (Remember we'd also need frescobaldi/frescobaldi#1832 to remove the last bits of Poppler code there.) |
Merged
|
Ok, let's wait for the review of @jeanas |
|
In case we decide to remove Poppler, we should remember to remove it also from the docs. Postponed after 1.0.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This most obviously includes the Poppler backend, but also the EPS exporter.
As discussed under #32, there is currently no python-poppler-qt6, and little interest in creating one now that QtPdf satisfies our needs. It would therefore make sense to drop Poppler support rather than continue to include a feature we do not need using a binding we do not control.
This PR is mutually exclusive with #33 and intended to follow frescobaldi/frescobaldi#1832, which removes the last Poppler-dependent features from Frescobaldi.