Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chart): remove invalid template expressions from crds #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(chart): remove invalid template expressions from crds #16

wants to merge 1 commit into from

Conversation

pascaliske
Copy link

Fixes #14.

Changes proposed on the PR:

@pascaliske pascaliske mentioned this pull request Dec 21, 2024
Open
@samof76 samof76 self-requested a review January 21, 2025 08:47
samof76
samof76 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@samof76 samof76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascaliske
Copy link
Author

pascaliske commented Jan 23, 2025 •
edited
Loading

With the approving review, can we merge this in the near future?

Should be fairly simple to test and release, in my opinion... 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samof76 samof76 samof76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm CRD invalid due to templating variables
2 participants
@pascaliske @samof76