feat: add support for user defined ami filters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqmanbazran
changed the title
hskiba
pushed a commit
to frgrisk/terraform-aws-turbo-deploy
that referenced
this pull request
Oct 30, 2024
Previously, the filters used for determining what AMIs are shown in the frontend is hardcoded inside the lambda function. The aim of this PR is to make it so the user can define it from the turbo module. This PR is tied to this [PR](frgrisk/turbo-deploy#41) in the Turbo Deploy repository.
hskiba
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the filters used for listing the AMIs in the frontend was hardcoded inside the lambda go function. This PR aims to make it so that the filters can be defined during the infrastructure deployment instead.
This PR is tied to this PR in the terraform-aws-turbo-deploy repository