-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scene bindings #439
Scene bindings #439
Conversation
Cool, will take a look at the PR this weekend.
Maybe While we are doing this, maybe see if we can reference other scenes (and children)? Maybe reference scene by name? like we do with object? That way we could do: scene_name.object_name.transform.etc |
Yes, that was the most logical way of doing it but I launched just the first and simplest way to do it... I don't know if I will be able to do as
Indeed, this would be the last step, hehehe, let's see if we can arrive there 😅 |
I simplified some code 41af7a2 |
Renamed the bindings to:
Makes more sense IMHO. |
Indeed, that was my bet too. I didn't know you could include a dot in the binding name, hehehe. But yes, much better this way 👏🏻 |
Ideally we should do it this way, we reference whatever scene we want by property name and recursivly can go through scene properties and children properties etc |
I think this PR is good enough for v1.0 (we can improve/add more features for v1.1). I don't see any issues/regressions with the changes. Will merge unless there are any objections. |
I do agree 🥳 |
I've been playing with this for a while, I hope you like it.
I have implemented new bindings to take information from the active scene:
$sceneFPS
(probably the most important and useful one)$sceneWidth
$sceneHeight
$sceneStart
$sceneEnd
They are pretty explanatory 😉
What I don't know if it is the good way to do it or there is an easier one... Changing the names is easy so if you don't like this name convention let's discuss it.
I fixed a small bug that limited the binding name length to just 6 digits, take it into account.
The only "bug" I found is that if you have an expression with any of these new bindings and you change the Scene settings, the expression is not automatically updated... I guess this is simple, but I haven't done it.
Let me know about it 😄
Cheers