FR-14813 - SDK improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add option to use asset links instead of custom url scheme (bypass continue button) - Fix intent filters
amirjaron
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several key updates and fixes to improve the authentication process and the overall user experience. The changes are as follows:
Navigation to Login on Hosted Login Callback Failure: Implemented a feature where the user is automatically navigated to the login page if the callback from the hosted login fails. This ensures a smoother user experience by avoiding dead ends in the authentication process.
Addition of Error Pages to Prevent Infinite Loops: Introduced error pages that are displayed when certain failures occur. This approach replaces the previous behavior where the user might get stuck in an infinite loop. The error pages provide clear information about the issue, improving transparency and user experience.
Fix for Custom Social Login Redirection: Addressed an issue with the redirection process in custom social logins. The fix ensures that users are correctly redirected after authenticating with a social login provider, streamlining the login process.
Option to Use Asset Links Instead of Custom URL Scheme: Added a new feature allowing the use of asset links instead of custom URL schemes. This enhancement bypasses the need for a continue button, thus simplifying the process and reducing user interaction steps.
Intent Filters Fix: Resolved issues with the intent filters, ensuring they work as expected. This fix improves the app's ability to handle various intents and deep links correctly.
README Update: The README file has been updated for clarity and to reflect the latest changes. This includes the addition of new instructions and the updating of existing information to assist developers and users in understanding and using the app effectively.
Overall, these changes aim to enhance the user experience, increase the reliability of the login process, and provide better information and guidance through the updated documentation.