FR-18338.3 #86
Open
FR-18338.3 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2024 18:31
|
@frontegg-david I've added comments to main classes please check. |
|
@alex-minaiev-frontegg could you please fix conflicts first? |
added 2 commits
November 13, 2024 10:14
# Conflicts: # android/src/main/java/com/frontegg/android/AuthenticationActivity.kt # android/src/main/java/com/frontegg/android/FronteggAuth.kt # android/src/main/java/com/frontegg/android/embedded/FronteggWebClient.kt # android/src/main/java/com/frontegg/android/embedded/FronteggWebView.kt # android/src/main/java/com/frontegg/android/services/RefreshTokenJobService.kt
| * @property observable is the Subject of NullableObject; | ||
| * @property value is the read only value of [ReadOnlyObservableValue]; | ||
| */ | ||
| abstract class ReadOnlyObservableValue<T>(value: T) { |
There was a problem hiding this comment.
abstraction layer introduces additional complexity without providing clear advantages for most use cases
| } | ||
| } | ||
|
|
||
| fun scheduleTimer(offset: Long) { |
There was a problem hiding this comment.
add check if the token is already expired before scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was founded on https://frontegg.atlassian.net/browse/FR-18338 point 3
Created
FronteggAppandFronteggAuthinterfaces for separation interface and realization and provided to customers only necessary methods and properties to avoid accessing the inner implementation of methods and properties.New Component:
FronteggAppService- implementation ofFronteggAppinterface.FronteggInnerStorage- store all necessary information about SDK running (baseUrl, clientId, applicationId, etc.). Created to avoid usingFronteggAppandFronteggAppServiceby SDK components.FronteggAuthService- implementation ofFronteggAuthinterface.FronteggAppLifecycle- separate object for listening to application Lifecycle Events. Created to encapsulate all data and methods responsible forAppLifecycle(encapsulation Principle of OOP).FronteggRefreshTokenTimer- separate object for managing RefreshTokenTimer. Created to encapsulate all data and methods responsible forRefreshTokenTimer(encapsulation Principle of OOP).RefreshTokenServicewithRefreshTokenJobService- to avoid confusion with SDK Services.ReadOnlyObservableValue- usingObservableValuecustomer could change thevalueofObservableValue.ReadOnlyObservableValuelocksetability ofvalue.