Deprecate getSessionOnEdge with backward compatibility #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
frontegg-david
commented
Nov 26, 2024
•
frontegg-david
commented
- Deprecate getSessionOnEdge with warning instead of throwing error
- Resolve issue related to the AppDir architecture that the new cookies were not being forwarded to the server component after refreshing the token in the middleware.
frontegg-david
requested review from
aviadmizrachi,
amirjaron,
MaxArnautFrontegg,
TomerFrontegg,
raz-shlomo-frontegg,
mariavlasov,
doregg,
eran-frontegg and
vladFrontegg
as code owners
…github.com/frontegg/frontegg-nextjs into revert-support-for-old-get-session-on-edge
WhatIsLoveXXX
approved these changes
Nov 29, 2024
vladFrontegg
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.