Ignore 404s #132
Merged
Ignore 404s #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
reviewed
Jan 9, 2024
Co-authored-by: Nikhil Benesch <[email protected]>
mariavlasov
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code, if the Delete function returns any error, this error is immediately returned, which has caused us problems as it includes the case where the error is a 404 (resource not found). This is the expected scenario when the resource is already deleted.
The change updates error handling to specifically check if the error is not a 404. If the error is anything other than a 404, it's returned. Should also allow adding additional error-handling cases in the future.