ESLint formatter configs #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thxxx! i tested quickly on a deploy, working fine. merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MrSunshyne
I added the changes from your commit & a few additional rules, formatted the code with
pnpm run lin --fix, then fixed all errors thrown by ESLint.I also added the recommended
settings.jsoncontents from @antfu/eslint-config's docs. It seems thateditor.codeActionsOnSaveis what ESLint is looking at to know to format the code on save.P.s. I can confirm: format on save is now working! Reloading VSCode didn't work. I had to restart the ESLint server manually.
I'm not sure about the warnings though. I'm thinking maybe there are some special cases, e.g. unused variables were kept in the codebase for easy access during testing? If not, then, let me know. I'll fix the warnings as well.