Skip to content

Commit

Permalink
Remove INPUTS environment variable to avoid docker arg length limit (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
jason-fugue authored Apr 21, 2020
1 parent c22b3ce commit c37e076
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ define LDFLAGS
-X \"github.com/fugue/zim/cmd.Version=$(VERSION)\" \
-X \"github.com/fugue/zim/cmd.GitCommit=$(GITCOMMIT)\"
endef
CLI_BUILD = $(GO) build -ldflags="$(LDFLAGS)"
CLI_BUILD = $(GO) build -ldflags="$(LDFLAGS) -s -w"

# Variables relating to the Zim CloudFormation stack
STACK_NAME ?= zim
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,6 @@ in order to provide Rule commands some context:
* `RULE` - the Rule name, e.g. "build"
* `NODE_ID` - ID in Graph for the Rule, e.g. "myservice.build"
* `INPUT` - the relative path to the first input
* `INPUTS` - relative paths to all inputs (space separated)
* `OUTPUT` - the relative path to the first output
* `OUTPUTS` - relative paths to all outputs (space separated)
* `DEP` - the relative path to the first dependency
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.0
0.1.1
4 changes: 2 additions & 2 deletions cache/cache_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,6 @@ func TestCacheKey(t *testing.T) {
// fmt.Println(string(js))

// Known / golden values
assert.Equal(t, "f20681bd6fb3c73e31cb113b6d9ecd8f754aaeaf", key1Str)
assert.Equal(t, "8ed8160f86a649cca8cd942cf524e8130b0b246c", key2Str)
assert.Equal(t, "76210a1b69110fbab4368f0943451c43d132dbf2", key1Str)
assert.Equal(t, "dfc17112c86e320d733966fd38da435e4a0804c6", key2Str)
}
1 change: 0 additions & 1 deletion project/component_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ func TestNewComponentRule(t *testing.T) {
"DEP": "",
"DEPS": "",
"INPUT": "foo.go",
"INPUTS": "foo.go main.go go.mod",
"OUTPUT": "../../artifacts/foo",
"OUTPUTS": "../../artifacts/foo",
"VOLUME": "11",
Expand Down
1 change: 0 additions & 1 deletion project/rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ func (r *Rule) Environment() (map[string]string, error) {

tEnv := map[string]string{
"INPUT": firstIn,
"INPUTS": strings.Join(inputs, " "),
"OUTPUT": firstOut,
"OUTPUTS": strings.Join(outputs, " "),
"DEP": firstDep,
Expand Down
1 change: 0 additions & 1 deletion project/rule_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ func TestRule(t *testing.T) {
"DEP": "test_results.txt",
"DEPS": "test_results.txt",
"INPUT": "main.go",
"INPUTS": "main.go",
"KIND": "",
"NAME": "foo",
"NODE_ID": "foo.build",
Expand Down
1 change: 0 additions & 1 deletion project/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ func TestStandardRunner(t *testing.T) {
"DEP": "",
"DEPS": "",
"INPUT": "main.go",
"INPUTS": "main.go",
"KIND": "flurble",
"NAME": "a",
"NODE_ID": "a.build",
Expand Down

0 comments on commit c37e076

Please sign in to comment.