Fixed data truncation for signed messages #6
+752
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2016 18:57
…each packge. The parsed result then gets concatenated.
|
@geoko86 Any chance you have an sample with this format that I can add to the tests? |
|
Hi Andrew, I don't have a sample that i can share at the moment. I'll try On Thu, Apr 14, 2016 at 7:06 PM Andrew Smith [email protected]
sent from mobile device. |
Most files could be unsigned, but some were failing. This commit successfully parses at least one example (received by email from Frank).
Bug fix and hack to allow unsigning certain files
Fixes an issue where more than one certificate would not be marshalled correctly. This is now tested against openssl * correctly marshal degenerate certificates * update DegenerateCertificates test * add marshalCertificateBytes function and test against openssl
* Added AES-128-GCM support to Encrypt() and Decrypt()
According to the specification, when AuthenticatedAttributes isn't included the pkcs7 content should be used. Fixes fullsailor#9
I believe I was lied to. (or followed out of date advice)
OID 2.16.840.1.101.3.4.1.2
Since Go 1.10, the SignatureAlgorithm is now validated against the public key type. It was "working" before because the Amazon key used DSA with SHA1, and so the RSA/DSA mismatch didn't matter since the SHA1 hash type did. This uses some unexported code from `crypto/x509` that looks up a signature algorithm for a given `pxix.AlgorithmIdentifier` Fixes fullsailor#27 Fixes fullsailor#28 Fixes fullsailor#29
App Store receipts have an unusual DigestEncryptionAlgorithm, this may be because it doesn't have any authenticated attributes. If the new strategy for determining the correct x509.SignatureAlgorithm fails, we fallback to the old SHA1WithRSA algo.
Go 1.10 is more strict about Asn.1 annotations. This removes the incorrect “explicit” annotation from encryptedContentInfo.EncryptedContent. I’m also using openssl to generate the fixture now so that we aren’t testing with our own output for `Decrypt()` Fixes fullsailor#31
The content type should be oidData. Fixes fullsailor#24
…cted-when-running Georg/ch6977/esb race condition detected when running
chrisccoulson
pushed a commit
to chrisccoulson/pkcs7
that referenced
this pull request
Apr 25, 2020
Minor fixes to implement addon signing in firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that data gets truncated on signed messages because only the first ASN.1 data structure was parsed.
The fix now loops over any rest that comes back from ans1.Unmarshal and tries to unmarshal that rest again.