Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve:
locality
every time even when address is pretty much defined, so we can rely onadministrative_area_level_3
as fallback forcity
value. [Source from google] (https://developers.google.com/maps/documentation/places/web-service/supported_types#table3)state
, such location can't fit in this library, e.g.Copenhagen, Denmark
, proposed solution is to create dummy state to link city and country, i.e.locality
->unknown state
->country
ALLOW_DUMMY_ADDRESSES
toFalse
insetting.py
will stop saving dummy address, in my case, I wanted to raise error you use instead of silently storing dummy datastate_code
with more than8
chars is raising error, user has nothing to do other than selecting same address, so I've changed the handling to trim the extra chars, thestate_code
is invalid from google anyway so I just logged a warning.pyproject.toml
to fixpip install