Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Fix issue #28: cannot read property 'pathname' of undefined #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix issue #28: cannot read property 'pathname' of undefined #29

wants to merge 4 commits into from

Conversation

mrmuhammadali
Copy link

I was getting errors while configuring the plugin, I opened an issue so I thought why not I solve it myself. So here are the steps I did:

  1. Created flatCombineReducers utility which merges reducers without need of a key like combineReducers does.
  2. Created a routerReducer which is required by connected-router-redux
  3. Merged router reducer and root reducer, i.e. routerReducer and reducer
  4. Replaced store reducer with the merged reducer.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2018

CLA assistant check
All committers have signed the CLA.

@mrmuhammadali mrmuhammadali changed the title Fixes issue #28: cannot read property 'pathname' of undefined Fixing issue #28: cannot read property 'pathname' of undefined Dec 9, 2018
@mrmuhammadali mrmuhammadali changed the title Fixing issue #28: cannot read property 'pathname' of undefined Fix issue #28: cannot read property 'pathname' of undefined Dec 9, 2018
@mrmuhammadali
Copy link
Author

@KevinGrandon Can you look into this PR?

@KevinGrandon
Copy link
Contributor

Thanks for the PR. We really want to get this landed, but can't quite yet due to the following:

  • This is likely an error due to a newer version of the connected router.
  • We can't upgrade the connected router due to requiring React 15 support.

We are working on a roadmap for React 15, and will revisit this as soon as we have React 15 deprecation planned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants