This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
add logic to maintain cluster level information, namespace info, and table info in catalog manager #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table info in catalog manager
This was
linked to
issues
Nov 24, 2020
* K2 adapter GetRowID implementation * Handle null values in MakeSKVRecordWithKeysSerialized. Revise some comments Co-authored-by: Justin Funston <[email protected]>
This reverts commit 05d4bfd.
jerryhfeng
suggested changes
Nov 30, 2020
jfunston
suggested changes
Dec 1, 2020
jfunston
reviewed
Dec 1, 2020
jerryhfeng
suggested changes
Dec 2, 2020
This was referenced Dec 2, 2020
… it hasn't been ended in the destructor
jerryhfeng
previously approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Approve this change, but still there a a few issues we should discuss in group, especially the mapping of schema between PG and SKV. We can make the change resulted from discussion later after this PR though. Suggest we discuss this in this afternoon meeting.
iafuture
suggested changes
Dec 4, 2020
iafuture
reviewed
Dec 7, 2020
iafuture
reviewed
Dec 7, 2020
johnfangAFW
commented
Dec 7, 2020
iafuture
approved these changes
Dec 9, 2020
jfunston
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work consists of
Not included and will be addressed by new PRs