Implement eager parsing, getting rid of lifetime on StyleSource #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futursolo
reviewed
Apr 16, 2022
futursolo
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR angled towards #70. In evaluating the existing API, the lifetime of on
StyleSource, existing only for theparserfeature, has been removed. Raw css now gets parsed eagerly and early during conversion into aStyleSource. The feature gatedFrom<str>, ... impls have been changed toTryFrom<str>, ...This doesn't change the usage for the average user working with
css!and other macros. Most of the time (even in existing API) the lifetime was assumed to be'staticanyway.