fix: support calls in assignments #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Kotlin, we can write code like:
```
package annotation.test
public object Test {
fun f1(context : Context) {
Foo(context).elem = var1
}
}
```
where `Foo(context).elem = var1` assigns `var1` to an object constructed
in that line.
More generally, the result of calls can be shared objects that we wish
to assign to. Therefore, expressions that can be on the left hand of
assignments (primary expressions) need to include calls.
Test plan: parse the example given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kotlin, we can write code like:
where
Foo(context).elem = var1assignsvar1to an object constructed in that line.More generally, the result of calls can be shared objects that we wish to assign to. Therefore, expressions that can be on the left hand of assignments (primary expressions) need to include calls.
Test plan: parse the example given