Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small pythonic refactorings #129

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

reinvantveer
Copy link

@reinvantveer reinvantveer commented Mar 13, 2021

Hi @g-sherman thank you for sharing your plugin builder, it has been a very big help in getting started with QGIS plugin development. I'd like to contribute a few changes and I'll start small. I don't really enjoy huge PRs, so it's basically a few simple proposals to clean up a bit in the Python code:

  • I dropped the "Import python stuff" comment, if you don't mind
  • single-line the imports (for readability, mostly, got rid of the brackets)
  • Python comments take a space after the "#"-sign which I refuse to call a "hashtag" 😛; there's probably more I'm just checking if you agree.
  • There was (probably some copy/paste thing) an erroneous docstring for one of the methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant