Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid aCollectionOf property definition #163

Merged
merged 4 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions framework/json/configuration/entryTypeDefinition.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"$ref": "../common/beaconCommonComponents.json#/$defs/$schema"
},
"aCollectionOf": {
"description": "If the entry type is a collection of other entities, (e.g. a Dataset is a collection of Records), then this attribute must list the entities that can be included. One _collection_ can include more than one entry type (e.g. a Dataset in teh Beacon cdefault model could include Individuals, Biosamples, GenomicVariations, Analyses amnd Runs). In such cases in each individual response (e.g. `resultSetsResponse` of collections of type \"dataset\") will contain entries of a single entry type (e.g. biosamples) even if a dataset may contain records of multiple types.",
"includedConcepts": {
"$ref": "../common/basicElement.json",
"type": "array"
"description": "If the entry type is a collection of other entry types, (e.g. a Dataset is a collection of Records), then this attribute must list the entry types that could be included. One collection type could be defined as included more than one entry type (e.g. a Dataset could include Individuals or Genomic Variants), in such cases the entries are alternative, meaning that a given instance of this entry type could be of only one of the types (e.g. a given Dataset contains Individuals, while another Dataset could contain Genomic Variants, but not both at once).",
"type": "array",
"items": {
"$ref": "../common/basicElement.json"
}
},
"additionallySupportedSchemas": {
Expand Down Expand Up @@ -76,4 +76,4 @@
],
"title": "",
"type": "object"
}
}
21 changes: 10 additions & 11 deletions framework/src/configuration/entryTypeDefinition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,16 @@ properties:
items:
$ref: ../common/referenceToAnSchema.yaml
aCollectionOf:
description: >-
If the entry type is a collection of other entities, (e.g. a Dataset
is a collection of Records), then this attribute must list the entities that
can be included. One _collection_ can include more than one entry type
(e.g. a Dataset in teh Beacon cdefault model could include Individuals, Biosamples,
GenomicVariations, Analyses amnd Runs). In such cases in each individual
response (e.g. `resultSetsResponse` of collections of type "dataset") will
contain entries of a single entry type (e.g. biosamples) even if a dataset
may contain records of multiple types.
includedConcepts:
type: array
description: If the entry type is a collection of other entry types, (e.g. a Dataset
is a collection of Records), then this attribute must list the entry types that
could be included. One collection type could be defined as included more than
one entry type (e.g. a Dataset could include Individuals or Genomic Variants),
in such cases the entries are alternative, meaning that a given instance of
this entry type could be of only one of the types (e.g. a given Dataset contains
Individuals, while another Dataset could contain Genomic Variants, but not both
at once).
type: array
items:
$ref: ../common/basicElement.yaml
filteringTerms:
description: >-
Expand Down
Loading