Add option to hide footer #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using this class to create a front page with TOC to include as the first page in the merged document. To do that, I first need to merge my documents to get the TOC object. Then I'm using the TOC object and another plugin to generate the front page. After that, I'm merging once more. But I can't have the footer generated both times, because it'll overlap. So I'm proposing a small change to allow the user to choose whether the footer should be generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this class to create a front page with TOC to include as the first page in the merged document.
To do that, I first need to merge my documents to get the TOC object. Then I'm using the TOC object and another plugin to generate the front page. After that, I'm merging once more.
But I can't have the footer generated both times, because it'll overlap. So I'm proposing a small change to allow the user to choose whether the footer should be generated.