Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing with User Configurable Memory Specification Options #348

Closed
wants to merge 2 commits into from

Conversation

wdeshazer
Copy link
Contributor

Reverts #346

Warning

WIP

Note

Previous PR was WIP but not Marked.

New approach: Memory Defaults are moving to Platform qsubs

Introduces User Configurable Memory Specification to gacode/shared/bin/gacode_qsub

  • Previously it was hardwired in Site Supplemental files in gacode/platform/qsub

Provisioned for -mem and -mem-per-cpu

Applied Precedence rules

  • Default -mem=16GB
  • Double specification by user
    • Warning
    • Default to user specified `-mem1
    • Otherwise use use specified values

Communicates select through environment variables

  • MEMPERNODE
  • MEMPERCPU
  • Logic nullifies other variable

Site Supplemental file responds correspondingly

  • Modified gacode/shared/bin/gacode_qsub
  • Modified Site Files
    • gacode/platform/qsub/qsub.PPPL
    • gacode/platform/qsub/qsub.OMEGA
  • Ran regression tests
    • Write regression tests to confirm behavior
  • Assess if gacode/shared/bin/gacode_qsub_multi needs same medicine
  • Peruse the remaining files in gacode/shared/bin to ensure compatibility
  • Peruse the remaining Site Files in gacode/platform/qsub to ensure compatibility

I have taken a cursory look at all files and don't see anything glaring, but it deserves more consideration

@wdeshazer wdeshazer requested a review from smithsp February 7, 2024 04:12
@wdeshazer wdeshazer self-assigned this Feb 7, 2024
@wdeshazer
Copy link
Contributor Author

Checklist of Confirmed Compatible files

gacode/shared/bin

AZURE-COMET
  • qsub.AZURE
  • qsub.AZURE_GPU
  • qsub.AZURE_HB2
  • qsub.AZURE_HB2_1k
  • qsub.AZURE_HC
  • qsub.AZURE_SLURM
  • qsub.BANACH
  • qsub.CLOUD_GPU
  • qsub.COMET
  • qsub.CRUSHER
DAINT_PGI-HPC_ITER
  • qsub.DAINT_PGI
  • qsub.DROP
  • qsub.EDISON_CRAY
  • qsub.EDISON_IFORT
  • qsub.FREIA
  • qsub.Frontera_GCC
  • qsub.Frontera_IFORT
  • qsub.FRONTIER
  • qsub.GASUMMIT_GPU
  • qsub.HPC_ITER
IRIS-OMEGA
  • qsub.IRIS
  • qsub.KAIROS
  • qsub.LOKI
  • qsub.MARCONI
  • qsub.MARCONI_KNL
  • qsub.MARCONI_LEONARDO
  • qsub.MARCONI_SKL
  • qsub.MINT
  • qsub.NURION
  • qsub.OMEGA
PPPL-STAMPEDE
  • qsub.PPPL
  • qsub.PPPL_atom
  • qsub.PPPL_gcc
  • qsub.PSFCLUSTER
  • qsub.SATURN
  • qsub.SATURN_GCC
  • qsub.SHENMA
  • qsub.STAMPEDE
  • qsub.STAMPEDE2_KNL_HT2_IFORT
  • qsub.STAMPEDE2_KNL_IFORT
  • qsub.STAMPEDE2_SKX_IFORT
SUMMIT-MARCONI
  • qsub.SUMMIT
  • qsub.SUMMITDEV_GPU
  • qsub.PERLMUTTER_GPU
  • qsub.PERLMUTTER_GPU_80G
  • qsub.PERLMUTTER_CPU
  • qsub.PERLMUTTER_CPU_Cray
  • qsub.SHELL
  • qsub.MARCONI_100G
  • qsub.MARCONI_A

gacode/shared/bin

gacode_getversion-update_gacode.csh
  • gacode_getversion
  • gacode_mpi_tool
  • gacode_platforms
  • gacode_printversion
  • gacode_qsub
  • gacode_qsub_multi
  • gacode_reg
  • gacode_reg_do
  • gacode_regression.py
  • gacode_release_new_version.sh
  • gacode_setup
  • gacode_setup.tcsh
  • gacode_sim_warn
  • osxlist.py
  • summit_tool
  • update_gacode.csh

@wdeshazer wdeshazer requested a review from jmcclena February 7, 2024 04:15
@wdeshazer wdeshazer closed this Feb 7, 2024
@wdeshazer wdeshazer deleted the user_mem_with_defaults branch February 7, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant