Qlmaster #350
Merged
Qlmaster #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed by using parentheses
remove weird kygrid_model=0 logic
|
@jmcclena Thank you. I would like to merge qlmaster into master soon, so this checking is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tested qlgyro on this branch, compared it to the OMFIT qlgyro implementation, and saw good agreement. The calculations are not exactly the same because I was using a slightly different radius in OMFIT with a non-simplified input.gacode to calculate the intensity.
OMFIT:
Qi = 13.936865
Qe = 70.20317
fortran:
Qi = 14.05400
Qe = 69.44498