Skip to content

Commit

Permalink
ci: code_style: run pycodestyle even if checkpatch has failed
Browse files Browse the repository at this point in the history
When checkpatch reports issues, it returns an error status which make
the code_style job fail as expected. However, by default when a job step
fails the subsequent ones are not executed. Therefore, pycodestyle is
skipped which is bad because we sometimes want to ignore some checkpatch
errors and we still want to detect Python issues.

This problem is fixed by adding a condition to the "Run pycodestyle"
step.

Signed-off-by: Jerome Forissier <[email protected]>
Acked-by: Jens Wiklander <[email protected]>
  • Loading branch information
jforissier committed Oct 26, 2022
1 parent 499f488 commit 32692b3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
fi
[ -z "$failed" ]
- name: Run pycodestyle
if: success() || failure()
run: |
# pycodestyle task
sudo -E bash -c "apt update -qq -y && apt install -qq -y pycodestyle"
Expand Down

0 comments on commit 32692b3

Please sign in to comment.