feat: chainlink oracle adapter #1006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have not been updated:
Crate versions that have been updated:
Runtime version has been increased. |
dmoka
reviewed
Feb 5, 2025
| @@ -121,6 +121,8 @@ impl Get<Multiplier> for TransactionPaymentMultiplier { | |||
| } | |||
| } | |||
|
|
|||
| pub const USDT: AssetId = 10u32; | |||
There was a problem hiding this comment.
Would not be better to read this from asset registry based on Location? Similarly what we have for DOT so
pub struct DotAssetId;
impl Get<AssetId> for DotAssetId {
fn get() -> AssetId {
let invalid_id =
pallet_asset_registry::Pallet::<crate::Runtime>::next_asset_id().defensive_unwrap_or(AssetId::MAX);
match pallet_asset_registry::Pallet::<crate::Runtime>::location_to_asset(DOT_ASSET_LOCATION) {
Some(asset_id) => asset_id,
None => invalid_id,
}
}
}
| } | ||
| } | ||
|
|
||
| impl<QuoteAsset, Runtime> ChainlinkOraclePrecompile<QuoteAsset, Runtime> |
There was a problem hiding this comment.
i probably dont get what Chainlink is doing, but why is this Chainlink specific? Do we do anything with the official Chainlink oracle network?
|
|
||
| /// Encoding is 7 bytes for precompile prefix 0x00000000000001, | ||
| /// followed by 1 byte for encoded OraclePeriod enum, 8 bytes for Source, and 4 bytes for AssetId. | ||
| pub fn encode_evm_address(asset_id: AssetId, period: OraclePeriod, source: Source) -> Option<EvmAddress> { |
There was a problem hiding this comment.
maybe we could do an invariant test for this to make sure it never panics?
| })?; | ||
|
|
||
| // use Router to get a route | ||
| let price = if source == [0; 8] { |
There was a problem hiding this comment.
I would make a constant for this magic number [0;8], like EMPTY_SOURCE or so
| exit_status: pallet_evm::ExitError::Other("Decimals not available".into()), | ||
| })?; | ||
|
|
||
| // use Router to get a route |
There was a problem hiding this comment.
Suggested change
| // use Router to get a route | |
| // In case of empty source, we retrieve onchain route |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993