Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] RegexParameterValidatorModel.regex_validation fails for bcftools annotate #19386

Closed
mvdbeek opened this issue Jan 8, 2025 · 2 comments

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Jan 8, 2025

... and a bunch of other IUC tests.

Traceback (most recent call last):
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/web/framework/decorators.py", line 346, in decorator
    rval = func(self, trans, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/webapps/galaxy/api/tools.py", line 596, in create
    return self.service._create(trans, payload, **kwd)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/webapps/galaxy/services/tools.py", line 172, in _create
    vars = tool.handle_input(
           ^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/__init__.py", line 1963, in handle_input
    expanded = self.expand_incoming(request_context, incoming=incoming, input_format=input_format)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/__init__.py", line 1856, in expand_incoming
    params, errors = self._populate(request_context, expanded_incoming, input_format)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/__init__.py", line 1902, in _populate
    populate_state(
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/__init__.py", line 431, in populate_state
    _populate_state_legacy(
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/__init__.py", line 635, in _populate_state_legacy
    _populate_state_legacy(
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/__init__.py", line 673, in _populate_state_legacy
    check_param(request_context, input, param_value, context, simple_errors=simple_errors)
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/__init__.py", line 294, in check_param
    param.validate(value, trans)
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/basic.py", line 422, in validate
    return super().validate(value, trans)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/basic.py", line 326, in validate
    validator.validate(value, trans)
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tools/parameters/validation.py", line 80, in validate
    RegexParameterValidatorModel.regex_validation(self.expression, value, self)
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tool_util/parser/parameter_validators.py", line 188, in regex_validation
    raise_error_if_valiation_fails(match is not None, validator, value_to_show=val)
  File "/tmp/tmp6qmxwayt/galaxy-dev/lib/galaxy/tool_util/parser/parameter_validators.py", line 673, in raise_error_if_valiation_fails
    assert message
           ^^^^^^^
AssertionError

from https://github.com/galaxyproject/tools-iuc/actions/runs/12668894193/job/35305447728#step:8:40790

@jmchilton
Copy link
Member

I see the issue - I'll open a fix. Sorry about that.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 10, 2025

Fixed in #19387

@mvdbeek mvdbeek closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants