Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.2] Fix for empty string in regex validator message. #19387

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[24.2] Fix for empty string in regex validator message. #19387

merged 1 commit into from
Jan 9, 2025
+2 −2

Conversation

jmchilton
Copy link
Member

xref #19386

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

jdavcs
jdavcs approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, test failures unrelated. Move out of draft?

@mvdbeek
Copy link
Member

mvdbeek commented Jan 9, 2025

I confirm that brings the IUC tests to parity with 24.1. It's somewhat of a tool bug that it uses an empty message attribute in the validator, but this seems solid. I don't think message="" (https://github.com/galaxyproject/tools-iuc/blob/main/tools/bcftools/bcftools_annotate.xml#L168) was intended as removing the default message.

@jmchilton jmchilton marked this pull request as ready for review January 9, 2025 14:38
@github-actions github-actions bot added this to the 25.0 milestone Jan 9, 2025
@mvdbeek mvdbeek merged commit 670f834 into galaxyproject:release_24.2 Jan 9, 2025
48 of 54 checks passed
@mvdbeek mvdbeek mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/tool-framework kind/bug
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmchilton @mvdbeek @jdavcs