Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix for empty string in regex validator message. #19387

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/galaxy/tool_util/parser/parameter_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,9 @@ def raise_error_if_valiation_fails(
raise AssertionError("Validator logic problem - computed validation value must be boolean")
if message is None:
message = validator.message
if message is None:
if not message:
message = DEFAULT_VALIDATOR_MESSAGE
assert message
assert message is not None
mvdbeek marked this conversation as resolved.
Show resolved Hide resolved
if value_to_show and "%s" in message:
message = message % value_to_show
negate = validator.negate
Expand Down
Loading