Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix folder listing via file browser #15950

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 18, 2023

Added in #15340 by accident.
Fixes:

RuntimeError: No active exception to reraise
  File "galaxy/web/framework/decorators.py", line 337, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/api/library_contents.py", line 130, in index
    for content in traverse(library.root_folder):
  File "galaxy/webapps/galaxy/api/library_contents.py", line 84, in traverse
    can_access, folder_ids = trans.app.security_agent.check_folder_contents(
  File "galaxy/model/security.py", line 1510, in check_folder_contents
    raise

in https://sentry.galaxyproject.org/share/issue/38df4490ff61415090c319ad0e16f1fa/

You can trigger this in the UI using the "Browse Files" if you're not an admin.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek added 2 commits April 18, 2023 12:29
Added in galaxyproject#15340 by accident.
Fixes:

```
RuntimeError: No active exception to reraise
  File "galaxy/web/framework/decorators.py", line 337, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/api/library_contents.py", line 130, in index
    for content in traverse(library.root_folder):
  File "galaxy/webapps/galaxy/api/library_contents.py", line 84, in traverse
    can_access, folder_ids = trans.app.security_agent.check_folder_contents(
  File "galaxy/model/security.py", line 1510, in check_folder_contents
    raise
```
in https://sentry.galaxyproject.org/share/issue/38df4490ff61415090c319ad0e16f1fa/
@github-actions github-actions bot added area/database Galaxy's database or data access layer area/testing area/testing/api labels Apr 18, 2023
@github-actions github-actions bot added this to the 23.0 milestone Apr 18, 2023
@mvdbeek mvdbeek merged commit 1a984f2 into galaxyproject:release_23.0 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants